Release 0.35: Remove Selectors #779
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #779 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 36 36
Lines 4332 4332
=======================================
Hits 3737 3737
Misses 595 595 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will collect all work related to removing
Selectors, Gibbs IDs, and indexingVarInfowith samplers. Since this will involve quite a lot of changes, we'll try a new pattern for code review: Changes will be made incrementally, trying to remove parts of the functionality at a time and getting tests to pass in between. Each such incremental change will be its own PR into this branch,release-0.35. Careful code review will be done at that stage. By the end of it this PR will probably be massive, and heavily breaking, but that can all then go intomasterwith only a light, final review.